Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lkl: fix install headers issue on Windows #578

Merged
merged 1 commit into from
Mar 3, 2025

Conversation

tavip
Copy link
Member

@tavip tavip commented Mar 3, 2025

Windows multiprocessing support in Python has restrictions around the use of global variables. Create an Installer class and keep the state there instead of in global variables.

Fixes #574

@tavip tavip force-pushed the lkl-fix-windows-headers-install branch from 6ec129e to 406988b Compare March 3, 2025 04:13
Windows multiprocessing support in Python has restrictions around the
use of global variables. Create an Installer class and keep the state
there instead of in global variables.

Signed-off-by: Octavian Purdila <[email protected]>
@tavip tavip force-pushed the lkl-fix-windows-headers-install branch from 406988b to 218748e Compare March 3, 2025 04:35
@tavip tavip requested a review from thehajime March 3, 2025 06:25
Copy link
Member

@thehajime thehajime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @tavip for the patch. all look good to me.

@thehajime thehajime merged commit 76c7be7 into lkl:master Mar 3, 2025
12 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Race condition when replacing headers
2 participants