Skip to content

Use startsWith() for perf test URL check to prevent false positives#19

Merged
llama90 merged 2 commits intofeat/e2e-performance-trackingfrom
copilot/sub-pr-18
Jan 3, 2026
Merged

Use startsWith() for perf test URL check to prevent false positives#19
llama90 merged 2 commits intofeat/e2e-performance-trackingfrom
copilot/sub-pr-18

Conversation

Copy link
Contributor

Copilot AI commented Jan 3, 2026

The special response URL check /test/perf-test-mock could match legitimate Slack URLs containing this substring anywhere in the path, causing incorrect mock behavior.

Change:

// Before: substring match anywhere in URL
if (responseUrl.includes('/test/perf-test-mock')) {

// After: exact prefix match
if (responseUrl.startsWith('https://hooks.slack.com/test/perf-test-mock')) {

This prevents false positives on URLs like https://hooks.slack.com/services/T123/B456/xyz/test/perf-test-mock/abc while correctly matching the exact mock URL generated by performance tests.


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

…icity

Co-authored-by: llama90 <6668548+llama90@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Jan 3, 2026

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • googlechromelabs.github.io
    • Triggering command: /usr/local/bin/node node install.mjs (dns block)
  • https://storage.googleapis.com/chrome-for-testing-public/143.0.7499.169/linux64/chrome-linux64.zip
    • Triggering command: /usr/local/bin/node node install.mjs (http block)

If you need me to access, download, or install something from one of these locations, you can either:

Copilot AI changed the title [WIP] Add changes to improve E2E performance tracking Use startsWith() for perf test URL check to prevent false positives Jan 3, 2026
Copilot AI requested a review from llama90 January 3, 2026 14:42
@llama90 llama90 marked this pull request as ready for review January 3, 2026 16:03
@llama90 llama90 merged commit 042b37d into feat/e2e-performance-tracking Jan 3, 2026
@llama90 llama90 deleted the copilot/sub-pr-18 branch January 3, 2026 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants