feat(codedeploy): add Server platform Blue/Green deployment support#96
Open
feat(codedeploy): add Server platform Blue/Green deployment support#96
Conversation
Enhance CodeDeploy module to support Blue/Green deployments for EC2/On-Premises (Server) platform. ## Changes ### Deployment Style Support - Extend `deployment_style` block to all platforms (not just Lambda/ECS) - Set `deployment_option` based on deployment type: - BLUE_GREEN: WITH_TRAFFIC_CONTROL - IN_PLACE: WITHOUT_TRAFFIC_CONTROL ### Blue/Green Configuration - Add `deployment_ready_wait_time_in_minutes` variable (optional, default: 0) - Support manual approval wait time for deployment readiness ### Auto Scaling Groups Management - Add lifecycle `ignore_changes` for `autoscaling_groups` - CodeDeploy manages ASGs dynamically during Blue/Green deployments - Prevents Terraform drift for CodeDeploy-managed ASG changes ## Breaking Changes None - all changes are backward compatible with optional parameters. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Contributor
🔍 Terraform Check Results📊 Summary✅ All checks passed!
🔍 TFLint Details (0 issue(s))🔒 Trivy Security Details (29 issue(s))👤 Pusher: @llama90 | 🔄 Action: |
Remove lifecycle ignore_changes from module and document in README instead. ## Changes - Remove forced ignore_changes for autoscaling_groups - Add detailed documentation in README about Blue/Green ASG drift - Let users decide how to handle ASG drift in their own configurations ## Rationale - Modules should not force lifecycle behavior - Users should have control over ignore_changes - Better to document the issue and let users choose their approach Fixes module flexibility and follows Terraform best practices.
Contributor
🔍 Terraform Check Results📊 Summary✅ All checks passed!
🔍 TFLint Details (0 issue(s))🔒 Trivy Security Details (29 issue(s))👤 Pusher: @llama90 | 🔄 Action: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enhance CodeDeploy module to support Blue/Green deployments for EC2/On-Premises (Server) platform.
Changes
Deployment Style Support
deployment_styleblock to all platforms (not just Lambda/ECS)deployment_optionbased on deployment type:Blue/Green Configuration
deployment_ready_wait_time_in_minutesvariable (optional, default: 0)Auto Scaling Groups Management
ignore_changesforautoscaling_groupsBreaking Changes
None - all changes are backward compatible with optional parameters.
🤖 Generated with Claude Code