fix(tests): validate provider types exist in backward compat test#5226
Merged
bbrowning merged 10 commits intollamastack:mainfrom Apr 1, 2026
Merged
fix(tests): validate provider types exist in backward compat test#5226bbrowning merged 10 commits intollamastack:mainfrom
bbrowning merged 10 commits intollamastack:mainfrom
Conversation
derekhiggins
requested review from
ashwinb,
bbrowning,
cdoern,
ehhuang,
franciscojavierarceo,
leseb,
mattf and
raghotham
as code owners
meta-cla
bot
added
the
CLA Signed
Contributor
Author
looking closer, the error was correctly caught in the next step, I'll leave this open for review but happy to close if deemed redundant |
The backward compatibility test previously only validated YAML schema structure but did not verify that referenced provider types actually exist in the registry. This would have allowed breaking changes like renaming "meta-reference" to "builtin" (236a230) to pass without detection(although the PR was correctly marked as a breaking change). This commit enhances the test to use `validate_and_prepare_providers()`, the same validation function the stack uses at runtime, which now checks: - Provider types exist in registry - No conflicts with auto-routed APIs - Provider deprecation warnings/errors Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com> Signed-off-by: Derek Higgins <derekh@redhat.com>
derekhiggins
force-pushed
the
more-compat
branch
from
d04001a to
dd43bb6
Compare
skamenan7
approved these changes
Mar 23, 2026
| # - Provider types exist in registry | ||
| # - No conflicts with auto-routed APIs | ||
| # - Provider deprecation warnings/errors | ||
| provider_registry = get_provider_registry() |
Contributor
There was a problem hiding this comment.
nit: Can you switch this to get_provider_registry(config) so the test is checking the same registry the stack would
actually use? Not blocking for the current fixtures, but I think it’d make the test more accurate.
bbrowning
approved these changes
Apr 1, 2026
Collaborator
bbrowning
left a comment
bbrowning
left a comment
There was a problem hiding this comment.
Looks good - feel free to address the minor comment from @skamenan7 later.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The backward compatibility test previously only validated YAML schema structure but did not verify that referenced provider types actually exist in the registry. This would have allowed breaking changes like renaming "meta-reference" to "builtin" (236a230) to pass without detection(although the PR was correctly marked as a breaking change).
This commit enhances the test to use
validate_and_prepare_providers(), the same validation function the stack uses at runtime, which now checks:--
See test passing here
https://github.com/llamastack/llama-stack/actions/runs/23156501249/job/67272595366
It should have failed and passed at the next stage (as it was marked as a breaking change)