chore(mypy): add type hints to provider_inline and provider_utils#5400
Closed
Elbehery wants to merge 1 commit intollamastack:mainfrom
Closed
chore(mypy): add type hints to provider_inline and provider_utils#5400Elbehery wants to merge 1 commit intollamastack:mainfrom
Elbehery wants to merge 1 commit intollamastack:mainfrom
Conversation
Elbehery
requested review from
ashwinb,
bbrowning,
cdoern,
ehhuang,
franciscojavierarceo,
leseb,
mattf and
raghotham
as code owners
meta-cla
bot
added
the
CLA Signed
Add type hints to make the following files pass strict mypy checking: - src/llama_stack/providers/inline/eval/builtin/eval.py: Add type annotations for dicts, fix variable shadowing, add assertions for non-streaming responses and non-None content, use proper union types for message lists - src/llama_stack/providers/utils/inference/embedding_mixin.py: Add config attribute declaration (Any type) and import Any from typing to fix "has no attribute config" error. Add sentence_transformers to mypy ignore_missing_imports list. Signed-off-by: Mustafa Elbehery <melbeher@redhat.com>
Elbehery
force-pushed
the
20260401_add_type_hints_providers_remote_module
branch
from
455ccea to
6fafd77
Compare
Elbehery
changed the title
Contributor
Author
|
closed in favor of #5399 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add type hints to make the following files pass strict mypy checking: