Repository navigation
Conversation
The worker forwards the queued bytes instead of re-encoding a map, and parses the payload for the span's model only when the span is sampled. Signed-off-by: Will Eaton <weaton@redhat.com>
Producers that know the model set it, so the worker labels its span without parsing the payload. The payload is still parsed for a sampled span when Model is empty. Signed-off-by: Will Eaton <weaton@redhat.com>
Transports that store the payload apart from the rest of the request read the envelope without scanning the prompt, then attach the payload bytes as stored. Signed-off-by: Will Eaton <weaton@redhat.com>
Signed-off-by: Will Eaton <weaton@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
api.SplitPayload,JoinPayload, andAttachPayload, which #452 and #458 use to store a request's payload apart from its envelope. Stacked on #456 (the last two commits are new).Release note