build: bump Go toolchain to 1.26.5#1998
Merged
Merged
Conversation
- also update base image for coordinator to algine with other 2 images Refs llm-d#1997 Signed-off-by: Wen Zhou <wenzhou@redhat.com>
github-actions
Bot
added
size/S
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the repository’s Go version baseline to Go 1.26.5, aligning local/module configuration and container build images with the newer toolchain as requested in #1997.
Changes:
- Bump the
godirective ingo.modto 1.26.5. - Update Go builder images in the Sidecar, EPP, Coordinator, and Builder Dockerfiles to Go 1.26.5.
- Update the Coordinator’s builder base image to use the
golang:1.26.5image.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| go.mod | Updates module Go version to 1.26.5 to reflect the new toolchain baseline. |
| Dockerfile.builder | Bumps the builder container base image to Go 1.26.5. |
| Dockerfile.epp | Updates the EPP build stage Go image to Go 1.26.5. |
| Dockerfile.sidecar | Updates the sidecar build stage Go image to Go 1.26.5. |
| Dockerfile.coordinator | Updates the coordinator build stage Go image to Go 1.26.5 (and switches builder image source). |
- golangci-lint v2.8.0 is built with Go 1.25 v2.10.0 is the first release built with Go 1.26. - update code to pass lint Signed-off-by: Wen Zhou <wenzhou@redhat.com>
github-actions
Bot
added
kind/feature
elevran
reviewed
Jul 14, 2026
elevran
reviewed
Jul 14, 2026
elevran
left a comment
elevran
left a comment
Collaborator
There was a problem hiding this comment.
/lgtm
not approving in case you want to fix the nit on predictedlatency dataproducer.
Collaborator
|
From PR description.
Which file in PR addresses this? |
Member
Author
|
Signed-off-by: Wen Zhou <wenzhou@redhat.com>
elevran
approved these changes
Jul 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #1997
Release note (write
NONEif no user-facing change):