-
Notifications
You must be signed in to change notification settings - Fork 9
Make Pipeline::run() const #181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: koparasy <[email protected]>
Co-authored-by: koparasy <[email protected]>
Co-authored-by: koparasy <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you remove these changes? We don't need them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed the .gitignore changes in commit 61cf300.
koparasy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot please check my comments and perform the necessary modifications
Co-authored-by: koparasy <[email protected]>
run()const is safe (it should only iterate and call Actions, not modify Pipeline state)run()method signature in pipeline.hpp to be constauto&toconst auto&to match const-correctness💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.