Add policy concept #183
Merged
Add policy concept #183
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koparasy
temporarily deployed
to
github-pages
GitHub Actions
Inactive
There was a problem hiding this comment.
Pull request overview
This PR introduces a Policy abstraction that serves as a factory for creating Pipeline objects. The Policy pattern separates the "what" (control flow and strategy) from the "how" (execution details in Actions), providing a clean architectural boundary for defining different workflow behaviors.
Key changes:
- Adds
Policyabstract base class withmakePipeline()factory method - Implements comprehensive unit tests covering normal execution and error handling
- Integrates the new test into the CMake build system
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/AMSlib/wf/policy.hpp | Defines the Policy abstract interface as a factory for Pipeline construction |
| tests/AMSlib/wf/policy.cpp | Provides comprehensive test coverage with mock implementations testing both success and failure scenarios |
| tests/AMSlib/wf/CMakeLists.txt | Registers the new policy unit test in the build system |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]>
koparasy
temporarily deployed
to
github-pages
GitHub Actions
Inactive
* Initial plan * Remove unnecessary __has_include preprocessor check Co-authored-by: koparasy <[email protected]> --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: koparasy <[email protected]>
koparasy
temporarily deployed
to
github-pages
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.