Add scalar size specifiers #45
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds scalar size specifiers like
i16,u8,f32, etc. to the type system. Addresses #30.Primarily this allows us to use smaller-size scalars in compound types in the C API. This wasn't possible before. For example, we can now import a list of floats like so:
Internally any shorter types are converted to double or int, so e.g. inputs passed as
i16are still stored asadiak_int. This is consistent with the C++ API and the way scalars are handled as varargs in C. It also requires no changes on the tool side. However since we know the real size of the input type we can address them correctly throughvoid*pointers.