-
Notifications
You must be signed in to change notification settings - Fork 110
cpp 17: Cleanup sycl and openmp target forall implementations #1959
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I marked this as ready for review to run gitlab CI, but I am still adding files |
|
@johnbowen42 note that we do not yet have an OpenMP target test job set up in out CI (we lost the one we had when SIerra was retired). So that needs to be tested and verified manually. There should be a build script to use in the scripts directory. |
rhornung67
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make sure you test OpenMP target manually for this PR since we not yet resurrected it in our regular CI
|
on Tioga, gfx90a, CCE 20.0.0. Will run on matrix and tuolumne as well |
|
on tuolumne: |
This PR is what I hope to be the final of a series of PRs simplifying RAJA's SFINAE std::enable_if overloads of forall and launch implementations. This PR primarily cleans up the SYCL and OpenMP target backends, but a couple of other simplifications are included here as well.