Skip to content

Conversation

@johnbowen42
Copy link
Contributor

@johnbowen42 johnbowen42 commented Dec 22, 2025

Rich and I discussed removing RAJA fault_tolerance header and macros offline, this PR is following up on that

@rhornung67
Copy link
Member

@johnbowen42 the FT macros are used in more files. I assume this is a WIP and you will be removing all use of the macros, correct?

Specifically, they appear in other files matching this pattern policy/*/{forall,launch}.hpp.

Also, there are CMake references in include/RAJA/config.hpp.inand in files in the RAJA/cmake directory.

@johnbowen42 johnbowen42 force-pushed the cleanup/bowen/fault-tolerance branch from 1f93adf to bfb8501 Compare December 22, 2025 18:58
@johnbowen42
Copy link
Contributor Author

@johnbowen42 the FT macros are used in more files. I assume this is a WIP and you will be removing all use of the macros, correct?

Specifically, they appear in other files matching this pattern policy/*/{forall,launch}.hpp.

Also, there are CMake references in include/RAJA/config.hpp.inand in files in the RAJA/cmake directory.

Yes, they should be gone now. I also removed some iterator fault tolerance methods, but let me know if I should keep those in

@johnbowen42 johnbowen42 marked this pull request as ready for review December 22, 2025 19:10
@adayton1
Copy link
Member

I think ubsan has checks for integer overflow, though I don't know if that is host code only.

Copy link
Member

@rhornung67 rhornung67 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please put everything related to RAJA_ENABLE_ITERATOR_OVERFLOW_DEBUG macro constant back in the code in this PR. We can remove it later if we discuss it and decide it's not needed anymore.

This reverts commit 2f45c79.
Copy link
Member

@rhornung67 rhornung67 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @johnbowen42 We can decide on the iterator stuff after the new year.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants