-
Notifications
You must be signed in to change notification settings - Fork 110
cleanup: Remove fault_tolerance header and macros #1966
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
|
@johnbowen42 the FT macros are used in more files. I assume this is a WIP and you will be removing all use of the macros, correct? Specifically, they appear in other files matching this pattern Also, there are CMake references in |
1f93adf to
bfb8501
Compare
Yes, they should be gone now. I also removed some iterator fault tolerance methods, but let me know if I should keep those in |
|
I think ubsan has checks for integer overflow, though I don't know if that is host code only. |
rhornung67
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please put everything related to RAJA_ENABLE_ITERATOR_OVERFLOW_DEBUG macro constant back in the code in this PR. We can remove it later if we discuss it and decide it's not needed anymore.
This reverts commit 2f45c79.
rhornung67
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @johnbowen42 We can decide on the iterator stuff after the new year.
Rich and I discussed removing RAJA fault_tolerance header and macros offline, this PR is following up on that