Skip to content

Bump cmake min required version #1967

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
rhornung67 wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Bump cmake min required version #1967

rhornung67 wants to merge 1 commit into from

Conversation

@rhornung67
Copy link
Member

@rhornung67 rhornung67 commented Dec 23, 2025

Summary

  • This PR bump CMake min required version to 3.24.
  • Newer compilers and language standards, such as C++20, work better with newer CMake versions.
  • LC systems support newer versions
  • CMake 3.24 is the lowest version supported in images we use for GH Actions testing

artv3
artv3 approved these changes Dec 23, 2025
View reviewed changes
Copy link
Member

@artv3 artv3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sounds good to me!

artv3
artv3 reviewed Dec 23, 2025
View reviewed changes
RELEASE_NOTES.md
* Build changes/improvements:
* Bump minimum CMake version required to 3.24.

* Bug fixes/improvements:
Copy link
Member

@artv3 artv3 Dec 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a big fan of updating the release_notes / change log per PR!

Copy link
Member Author

@rhornung67 rhornung67 Dec 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto. If we are disciplined enough to check on that for each PR review, we can do it.

Copy link
Member

@smithsg84 smithsg84 Dec 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just FYI, a check can be added to verify the release notes / changlog file has been changed. Used this on a prior project to remind people to update. Happy to add that if you want. It was both useful and annoying at times.

Copy link
Member Author

@rhornung67 rhornung67 Dec 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ooooo, that sounds good. Please make a PR or whatever needs to be done to add that.

@rhornung67
Copy link
Member Author

rhornung67 commented Dec 23, 2025 •
edited
Loading

Folks, the CI failures here are due to container images still being updated. I will re-trigger CI when it looked like the new versions are ready.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@artv3 artv3 artv3 approved these changes

@smithsg84 smithsg84 smithsg84 left review comments

@adayton1 adayton1 adayton1 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@rhornung67 @artv3 @adayton1 @smithsg84