Add kahan sum reduce helper class. #1969
Open
+305
−77
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a KahanSum class to help do Kahan sums. This also adds tests and generalizes the existing tests for reduce helper classes to accommodate slightly different interfaces.
MrBurmark
force-pushed
the
feature/burmark1/kahan
branch
from
eaba655 to
774e095
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This adds a KahanSum class to help do Kahan sums.
This also adds tests and generalizes the existing tests for reduce helper classes to accommodate slightly different interfaces.
The intention is to potentially use this or something similar for checksums in llnl/RAJAPerf#608.