Add more variants for Massvec3D #589
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artv3
commented
Nov 25, 2025
src/apps/MASSVEC3DPA-Hip.cpp
Outdated
| startTimer(); | ||
| for (RepIndex_type irep = 0; irep < run_reps; irep = irep + 1) { | ||
|
|
||
| RAJA::launch<launch_policy>( |
Member
Author
There was a problem hiding this comment.
TODO: move the RAJA code into a function that is templated on policies to avoid duplicated code...
Member
There was a problem hiding this comment.
How much of the body could be a macro?
artv3
commented
Nov 25, 2025
src/apps/MASSVEC3DPA-Hip.cpp
Outdated
|
|
||
| const int bdx = blockDim.x; //block size is the same for xyz... | ||
| //const int bdy = blockDim.y; | ||
| //const int bdz = blockDim.z; |
Member
Author
There was a problem hiding this comment.
Is it worth adding the different dimensions to match the RAJA variant?
Member
There was a problem hiding this comment.
What about the argument runtime_block_size above though? Should that be removed?
artv3
commented
Dec 2, 2025
| } | ||
|
|
||
| template<typename inner_x, typename inner_y, typename inner_z, typename RESOURCE> | ||
| void MASSVEC3DPA::runRAJAImpl(RESOURCE &res) |
Member
Author
There was a problem hiding this comment.
True to the RAJA mantra, "Change the policy not src code!"
Member
Author
|
TODO: remove Bt as it is not used. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DRAFT-PR. -- This MR adds the option to store threadblock info in the launch ctx avoiding calling blockDim.x,y,z during the loop methods in raja launch