Skip to content
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
ad8e3f6
Initial commit of new ops
davidbeckingsale Mar 31, 2025
07bbc3d
Update RM to use more operations
davidbeckingsale Mar 31, 2025
2d15ce3
Add SYCL and OpenMP target
davidbeckingsale Mar 31, 2025
3d96145
Add generic_reallocate
davidbeckingsale Mar 31, 2025
e3b1914
Continue refining implementation
davidbeckingsale Mar 31, 2025
244940e
Checkpoint
davidbeckingsale Apr 1, 2025
5f66c80
Adding tests and cleaning
davidbeckingsale Apr 1, 2025
cada71e
Fixing tests and other compile errors
davidbeckingsale Apr 1, 2025
40620e4
Update to fix original tests
davidbeckingsale Apr 1, 2025
d0d1d34
Add ifdef for old vs. new ops
davidbeckingsale Apr 15, 2025
f9712b9
Remove event recording and clean up prefetch/reallocate
davidbeckingsale Apr 15, 2025
817e569
Fix reallocate implementation to prioritize generic implementation fo…
davidbeckingsale Apr 22, 2025
0536cf7
Refactor reallocate to use a single platform-independent implementation
davidbeckingsale Apr 22, 2025
d59b7b0
Remove platform-specific reallocate implementations for SYCL and Open…
davidbeckingsale Apr 22, 2025
386c813
Correct ResourceManager implementation of reallocate with new ops
davidbeckingsale Apr 22, 2025
f03ad83
Merge branch 'develop' into feature/operation-v2
davidbeckingsale Jul 8, 2025
708ae0a
Merge branch 'develop' into feature/operation-v2
davidbeckingsale Sep 12, 2025
21e2ed1
Switch to non-deprecated functions
davidbeckingsale Sep 17, 2025
3c06206
Add benchmark and compilation fixes
davidbeckingsale Sep 18, 2025
9bf41b1
Make bounds checking an option
davidbeckingsale Sep 18, 2025
2886c02
Fixes for CUDA and HIP
davidbeckingsale Sep 26, 2025
33e46e2
Address issues related to bytes vs. count
davidbeckingsale Dec 19, 2025
0ecc828
correctly forward ctx
davidbeckingsale Dec 22, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -203,16 +203,11 @@ if (UMPIRE_ENABLE_TESTS)
add_subdirectory(tests)
endif ()

if (UMPIRE_ENABLE_DEVELOPER_BENCHMARKS)
if (UMPIRE_ENABLE_BENCHMARKS)
add_subdirectory(benchmarks)
if ((NOT CMAKE_BUILD_TYPE) OR (NOT ${CMAKE_BUILD_TYPE} STREQUAL "Release"))
message("-- Warning: CMAKE_BUILD_TYPE not set to Release, benchmark information will not be reliable for this build!")
endif()
else()
if (UMPIRE_ENABLE_BENCHMARKS)
message("-- Warning: Benchmarks will not be built. If you want to build with benchmarks,\n"
" set UMPIRE_ENABLE_DEVELOPER_BENCHMARKS to On.")
endif()
endif ()

if (UMPIRE_ENABLE_EXAMPLES)
Expand Down
6 changes: 3 additions & 3 deletions Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,8 @@ ENV GTEST_COLOR=1
COPY . /home/umpire/workspace
WORKDIR /home/umpire/workspace/build
RUN cmake -DUMPIRE_ENABLE_DEVELOPER_DEFAULTS=On -DCMAKE_CXX_COMPILER=clang++ -DCMAKE_C_COMPILER=clang \
-DUMPIRE_ENABLE_C=On -DCMAKE_CXX_FLAGS="-fsanitize=address" -DENABLE_TESTS=On -DUMPIRE_ENABLE_TOOLS=On \
-DUMPIRE_ENABLE_ASAN=On -DUMPIRE_ENABLE_SANITIZER_TESTS=On .. && \
-DUMPIRE_ENABLE_C=On -DCMAKE_CXX_FLAGS="-fsanitize=address" -DENABLE_TESTS=On -DUMPIRE_ENABLE_TOOLS=On \
-DUMPIRE_ENABLE_ASAN=On -DUMPIRE_ENABLE_SANITIZER_TESTS=On .. && \
make -j 2 && \
ctest -T test -E operation_tests --output-on-failure

Expand All @@ -48,7 +48,7 @@ ENV GTEST_COLOR=1
COPY . /home/umpire/workspace
WORKDIR /home/umpire/workspace/build
RUN cmake -DUMPIRE_ENABLE_DEVELOPER_DEFAULTS=On -DCMAKE_CXX_COMPILER=g++ -DENABLE_CUDA=On -DCMAKE_CUDA_COMPILER=/usr/local/cuda/bin/nvcc -DCMAKE_CUDA_ARCHITECTURES=70 .. && \
make -j 16
make -j 8

# TODO: switch to ROCM 6
FROM ghcr.io/llnl/radiuss:hip-5.6.1-ubuntu-20.04 AS hip
Expand Down
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ else
DebugArgs=
endif

targets = asan clang10 clang11 clang12 clang13 gcc11 gcc7 gcc8 gcc9 hip hip.debug nvcc10 sycl umap_build
targets = gcc clang umap_build asan cuda hip sycl intel

$(targets):
DOCKER_BUILDKIT=1 docker build --target $@ --no-cache $(DebugArgs) .
Expand Down
101 changes: 54 additions & 47 deletions benchmarks/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -88,64 +88,71 @@ blt_add_target_compile_flags(
TO pool_stress_test
FLAGS ${UMPIRE_DISABLE_DEPRECATED_WARNINGS_FLAG})

if (UMPIRE_ENABLE_BENCHMARKS)
set (benchmark_depends gbenchmark umpire)
set (benchmark_depends gbenchmark umpire)

if (UMPIRE_ENABLE_OPENMP_TARGET)
set (benchmark_depends
${benchmark_depends}
openmp)
endif()
if (UMPIRE_ENABLE_OPENMP_TARGET)
set (benchmark_depends
${benchmark_depends}
openmp)
endif()

blt_add_executable(
NAME allocator_benchmarks
SOURCES allocator_benchmarks.cpp
DEPENDS_ON ${benchmark_depends})
blt_add_executable(
NAME allocator_benchmarks
SOURCES allocator_benchmarks.cpp
DEPENDS_ON ${benchmark_depends})

blt_add_benchmark(
NAME allocator_benchmarks
COMMAND allocator_benchmarks)
blt_add_benchmark(
NAME allocator_benchmarks
COMMAND allocator_benchmarks)

blt_add_executable(
NAME vendor_allocator_benchmarks
SOURCES vendor_allocator_benchmarks.cpp
DEPENDS_ON ${benchmark_depends})
blt_add_executable(
NAME vendor_allocator_benchmarks
SOURCES vendor_allocator_benchmarks.cpp
DEPENDS_ON ${benchmark_depends})

blt_add_benchmark(
NAME vendor_allocator_benchmarks
COMMAND vendor_allocator_benchmarks)

blt_add_executable(
NAME debuglog_benchmarks
SOURCES debuglog_benchmarks.cpp
DEPENDS_ON ${benchmark_depends})

blt_add_benchmark(
NAME vendor_allocator_benchmarks
COMMAND vendor_allocator_benchmarks)
if (UMPIRE_ENABLE_OPENMP)
set (benchmark_depends
${benchmark_depends}
openmp)

blt_add_executable(
NAME debuglog_benchmarks
SOURCES debuglog_benchmarks.cpp
NAME file_resource_benchmarks
SOURCES file_resource_benchmarks.cpp
DEPENDS_ON ${benchmark_depends})
endif()

if (UMPIRE_ENABLE_OPENMP)
set (benchmark_depends
${benchmark_depends}
openmp)
blt_add_executable(
NAME copy_benchmarks
SOURCES copy_benchmarks.cpp
DEPENDS_ON ${benchmark_depends})

blt_add_executable(
NAME file_resource_benchmarks
SOURCES file_resource_benchmarks.cpp
DEPENDS_ON ${benchmark_depends})
endif()
blt_add_benchmark(
NAME copy_benchmarks
COMMAND copy_benchmarks)

blt_add_executable(
NAME copy_benchmarks
SOURCES copy_benchmarks.cpp
DEPENDS_ON ${benchmark_depends})
blt_add_executable(
NAME inspector_benchmarks
SOURCES inspector_benchmarks.cpp
DEPENDS_ON ${benchmark_depends})

blt_add_benchmark(
NAME copy_benchmarks
COMMAND copy_benchmarks)
blt_add_benchmark(
NAME inspector_benchmarks
COMMAND inspector_benchmarks)

blt_add_executable(
NAME inspector_benchmarks
SOURCES inspector_benchmarks.cpp
DEPENDS_ON ${benchmark_depends})
blt_add_executable(
NAME copy_performance_benchmark
SOURCES op/copy_performance_benchmark.cpp
DEPENDS_ON ${benchmark_depends})

blt_add_benchmark(
NAME inspector_benchmarks
COMMAND inspector_benchmarks)
endif()
blt_add_benchmark(
NAME copy_performance_benchmark
COMMAND copy_performance_benchmark)
Loading
Loading