Updates mfem dependency to [email protected] #1751
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kennyweiss
added
bug
white238
approved these changes
Dec 24, 2025
kennyweiss
force-pushed
the
feature/kweiss/update-mfem
branch
from
e622d30 to
d4110da
Compare
kennyweiss
requested review from
Arlie-Capps,
BradWhitlock,
bmhan12,
gunney1,
jcs15c,
nselliott,
publixsubfan,
rhornung67 and
white238
kennyweiss
commented
Dec 26, 2025
| //! \brief Accessor for the size of the quadrature rule | ||
| AXOM_HOST_DEVICE | ||
| int getNumPoints() const { return m_nodes.size(); } | ||
| int getNumPoints() const { return static_cast<int>(m_nodes.size()); } |
Member
Author
There was a problem hiding this comment.
I fixed some type conversion warnings from msvc along the way.
(There are many more)
kennyweiss
commented
Dec 26, 2025
Member
Author
There was a problem hiding this comment.
Note: Some mfem-based shaping tests were failing after the upgrade to [email protected].
Some users were also experiencing memory-related issues w/ shaping against newer versions of mfem.
I think these fixes should resolve the user problem and work against [email protected] as well.
Mfem file type is *.mesh and we should add the background material that we are initializing
Calling mfem::QuadratureFunction::GetValues(int, mfem::DenseMatrix&) on the "positions" quadrature function can invalidate/corrupt the buffer. Use mfem::Reshape() instead. Note: This was tested against [email protected] and [email protected].
kennyweiss
force-pushed
the
feature/kweiss/update-mfem
branch
from
b6586a1 to
3fef819
Compare
kennyweiss
commented
Dec 26, 2025
Comment on lines
+234
to
+237
| ## Note that NUM_OMP_THREADS delegates to the corresponding argument | ||
| ## in blt_add_test() and sets the OpenMP environment variable OMP_NUM_THREADS. | ||
| ## When AXOM_ENABLE_OPENMP is set and NUM_OMP_THREADS is not provided, | ||
| ## this macros also sets the environment variable OMP_NUM_THREADS=1. |
Member
Author
There was a problem hiding this comment.
This update is for a request in #1749
Tag: @Arlie-Capps @rhornung67
white238
reviewed
Dec 26, 2025
|
|
||
| #if defined(AXOM_USE_MFEM) | ||
| #include "mfem.hpp" | ||
| #include "mfem/linalg/dtensor.hpp" |
Member
There was a problem hiding this comment.
Is this not included in the above header? Should this be reported to mfem?
Member
Author
There was a problem hiding this comment.
It's not:
- https://github.com/mfem/mfem/blob/8e3a7b90fc1934c33b66baafee10fabd1eca0dea/mfem.hpp#L46
- https://github.com/mfem/mfem/blob/master/linalg/linalg.hpp
- https://github.com/mfem/mfem/blob/master/linalg/dtensor.hpp
@v-dobrev, @tzanio -- is dtensor.hpp intentionally left out of mfem.hpp / linalg.hpp ?
white238
approved these changes
Dec 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
mfem::Reshape()instead ofQuadratureFunction::GetValues()(which was failing w/ [email protected]).TODO: