Skip to content

Conversation

@michaelmckinsey1
Copy link
Collaborator

@michaelmckinsey1 michaelmckinsey1 commented Sep 5, 2025

Description

This PR is blocked by:

  • Application is private repo - requires local clone of private scaffold repo
  • Depends on Adds Python bindings to Adiak Adiak#38
  • (not mandatory) Needing to set MPICH_GPU_SUPPORT_ENABLED=0 on coral2 otherwise GTL linker error
  • (ignore using roctx for now) -> (not mandatory) ScaFFold+rocm caliper=rocm hangs (for rocprof)
    • Test spack package with rocprof on another benchmark (we were using roctracer before so maybe it is this)
    • run debugger

Summary:

Reproducers:

# Tuolumne profile rocm kernels and mpi functions
$ rm -rf tuolumne/ && benchpark system init --dest tuolumne llnl-elcapitan cluster=tuolumne && rm -rf py-scaffold-sp && benchpark experiment init --dest py-scaffold-sp      --system tuolumne py-scaffold+rocm scaffold_path=/usr/WS1/mckinsey/ScaFFold-spack/      package_manager=spack-pip caliper=mpi,time,rocm
$ rm -rf wkp && benchpark setup py-scaffold-sp wkp && . wkp/setup.sh && . wkp/.latest-experiment.sh 

# Matrix profile cuda kernels and mpi functions
$ rm -rf matrix/ && benchpark system init --dest matrix llnl-matrix && rm -rf py-scaffold-sp-mat/ && benchpark experiment init --dest py-scaffold-sp-mat      --system matrix py-scaffold+cuda scaffold_path=/usr/WS1/mckinsey/ScaFFold-spack/      package_manager=spack-pip caliper=mpi,time,cuda
$ rm -rf wkp2 && benchpark setup py-scaffold-sp-mat wkp2 && . wkp2/setup.sh  && . wkp2/.latest-experiment.sh 

Adding/modifying a system (docs: Adding a System)

  • Update llnl-elcapitan and llnl-matrix

Adding/modifying a benchmark (docs: Adding a Benchmark)

  • Add experiment, application, and package for py-scaffold

Adding/modifying core functionality, CI, or documentation:

  • (optional) Gitlab tests - Cannot add unit tests for this benchmark until it is made public

@michaelmckinsey1 michaelmckinsey1 marked this pull request as ready for review October 14, 2025 18:24
@michaelmckinsey1
Copy link
Collaborator Author

Note - now working on matrix after rebasing for spack1.0

@michaelmckinsey1 michaelmckinsey1 changed the title [WIP] ScaFFold Install via Spack [WIP] ScaFFold Benchmark and spack-pip Package Manager Oct 14, 2025

homepage = "https://github.com/LLNL/Adiak"
url = "https://github.com/LLNL/Adiak/releases/download/v0.1/adiak-v0.1.1.tar.gz"
git = "https://github.com/TauferLab/Adiak"
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Depends on llnl/Adiak#38

@github-actions github-actions bot added the dependencies Pull requests that update a dependency file label Oct 15, 2025
@michaelmckinsey1 michaelmckinsey1 changed the title [WIP] ScaFFold Benchmark and spack-pip Package Manager ScaFFold Benchmark and spack-pip Package Manager Oct 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

application blocked dependencies Pull requests that update a dependency file experiment New or modified experiment feature New feature or request system New or modified system config

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants