Skip to content

Conversation

@rfhaque
Copy link
Collaborator

@rfhaque rfhaque commented Nov 14, 2025

Description

This PR:

  1. Adds a variant to set the problem order in experiment.py and application.py
  2. Enables umpire in hypre and mfem
  3. Enables GPU aware MPI in mfem
  4. Enables compilation of caliper code blocks in the laghos code
  5. Adds performance testing parameters for laghos for the different testing modes

Adding/modifying a benchmark (docs: Adding a Benchmark)

  • If package.py upstreamed to Spack is insufficient, add/modify repo/benchmark_name/package.py plus: create, self-assign, and link here a follow up issue with a link to the PR in the Spack repo.
  • If application.py upstreamed to Ramble is insufficient, add/modify repo/benchmark_name/application.py plus: create, self-assign, and link here a follow up issue with a link to the PR in the Ramble repo.
  • Add/modify an experiments/benchmark_name/experiment.py to define an experiment

This PR depends on

@rfhaque rfhaque mentioned this pull request Nov 14, 2025
21 tasks
@github-actions github-actions bot added experiment New or modified experiment application labels Nov 14, 2025
@github-actions github-actions bot added the feature New feature or request label Dec 16, 2025
@rfhaque rfhaque requested a review from pearce8 December 16, 2025 16:48
@rfhaque rfhaque added the ready for review Ready for review label Dec 16, 2025
Copy link
Collaborator

@pearce8 pearce8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rfhaque Please:

  • fix docs (they don't build)
  • fix lint

@pearce8 pearce8 added changes requested Changes requested and removed ready for review Ready for review labels Dec 18, 2025
@github-actions github-actions bot added the system New or modified system config label Dec 20, 2025
@pearce8 pearce8 merged commit 6cfa837 into develop Jan 5, 2026
21 checks passed
@pearce8 pearce8 deleted the laghos branch January 5, 2026 16:04
@codecov-commenter
Copy link

Codecov Report

❌ Patch coverage is 64.28571% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 63.32%. Comparing base (a440f1a) to head (6da0597).
⚠️ Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
lib/benchpark/variables.py 58.33% 5 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1138      +/-   ##
===========================================
+ Coverage    63.25%   63.32%   +0.06%     
===========================================
  Files           45       45              
  Lines         3410     3419       +9     
  Branches       261      264       +3     
===========================================
+ Hits          2157     2165       +8     
- Misses        1244     1245       +1     
  Partials         9        9              
Files with missing lines Coverage Δ
lib/benchpark/scaling.py 91.30% <100.00%> (+0.12%) ⬆️
lib/benchpark/variables.py 76.19% <58.33%> (-3.20%) ⬇️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

application changes requested Changes requested experiment New or modified experiment feature New feature or request system New or modified system config

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants