-
Notifications
You must be signed in to change notification settings - Fork 5
enables streaming stderr #29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
There's an issue. If the process exits before all of the stderr has been read, then it gets lost. Looks like it's missing a double check on reading remaining lines in the pipes after process closes. Example: |
|
It is still not streaming. Add some sleeps between cerr output and you will see, like: The problem is that select.select ONLY works with file descriptors (fds) so that is all immediately ending. |
|
Another way to simplify if you wanted to is to only allow streaming form stderr and wait to even read stdout until after the process completes. Any future progress type stuff could be streamed to stdout. |
Closes #28