Skip to content

Conversation

@nselliott
Copy link
Contributor

This brings in updated features to the to_polygonal transformation of 2D structured AMR meshes:

  • Handles block rotations
  • Fixes case where a corner of a fine domain is not a vertex on the coarse mesh
  • Includes fields in the transformation, including communication of vertex field values from fine domains to coarse domains at hanging vertices, matching the communication of coordinate positions at those same vertices.

@nselliott nselliott requested review from agcapps and cyrush November 5, 2025 01:07
@nselliott nselliott marked this pull request as ready for review December 4, 2025 21:24
Copy link
Member

@cyrush cyrush left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nselliott this looks good.

More comments in conduit_blueprint_mpi_mesh about the cases would help our future selves.

Do you think we should we wire up the more complex bent grid example as part of this PR, or in a future PR (future PR is fine by me)

@nselliott
Copy link
Contributor Author

nselliott commented Dec 11, 2025

@nselliott this looks good.

More comments in conduit_blueprint_mpi_mesh about the cases would help our future selves.

Do you think we should we wire up the more complex bent grid example as part of this PR, or in a future PR (future PR is fine by me)

@cyrush I think we can do the bent grid in the next PR.

@nselliott nselliott merged commit 7ff33c5 into develop Dec 12, 2025
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants