Wire up Node::load and Node::save conduit_bin yaml case #1489
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cyrush
reviewed
Jan 5, 2026
Member
cyrush
left a comment
cyrush
left a comment
There was a problem hiding this comment.
Thanks for adding this! Please add a note to the changelog.
Question about detection logic:
Should we check if the json or yaml files exists before parsing to avoid an exception to detect the yaml case?
| } | ||
| // support explicit length 0 in a schema | ||
| else if (fetch_yaml_node_from_object_by_name(yaml_doc, yaml_node, "number_of_elements")) | ||
| else if (! fetch_yaml_node_from_object_by_name(yaml_doc, yaml_node, "number_of_elements")) |
| Schema s; | ||
| std::string ifschema = ibase + "_json"; | ||
| std::string ifschema_json = ibase + "_json"; | ||
| std::string ifschema_yaml = ibase + "_yaml"; |
Member
There was a problem hiding this comment.
Should we try to look for the file before parsing?
We may not have had the "file exists" helper when the json schema read was first implemented.
| std::string error_message; | ||
|
|
||
| std::string ifschema_json = stream_path + "_json"; | ||
| std::string ifschema_yaml = stream_path + "_yaml"; |
Member
There was a problem hiding this comment.
same q about checking if the file exists before trying to parse, to avoid exceptions in the case where we have yaml
| size_t nchildren = children().size(); | ||
| for(size_t i=0; i < nchildren;i++) | ||
| if (nchildren == 0) | ||
| { |
| for(size_t i=0; i < nchildren;i++) | ||
| if (nchildren == 0) | ||
| { | ||
| os << "[]" << eoe; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1313
Additionally fixes a longstanding bug preventing explicit length 0 in yaml schema
Additionally fixes a longstanding bug where empty objects or lists were not written correctly to yaml schema.
TODO need to understand how to choose to save conduit bin yaml. Will this be a new protocol? Something we prefer? What do we use to make this choice?
TODO need to add tests in
t_conduit_node_save_load.cpp