Skip to content

Conversation

@michaelmckinsey1
Copy link
Collaborator

@michaelmckinsey1 michaelmckinsey1 commented Dec 5, 2025

Support is required in the reader to add rocm kernels from Caliper files generated from rocm-activity-profile runs with roctx service. This matches the structure of how we read cuda-activity-profile files with nvtx. Also fix a bug when num_ranks is not an int

before
image

after
image

@michaelmckinsey1 michaelmckinsey1 self-assigned this Dec 5, 2025
@michaelmckinsey1 michaelmckinsey1 marked this pull request as draft December 5, 2025 23:40
@michaelmckinsey1 michaelmckinsey1 marked this pull request as ready for review December 5, 2025 23:56
@michaelmckinsey1 michaelmckinsey1 added the status-ready-for-review This PR is ready to be reviewed by assigned reviewers label Dec 15, 2025
@slabasan slabasan merged commit 028c71a into llnl:develop Dec 21, 2025
5 checks passed
@codecov-commenter
Copy link

Codecov Report

❌ Patch coverage is 5.00000% with 19 lines in your changes missing coverage. Please review.
✅ Project coverage is 61.22%. Comparing base (4f599be) to head (949b2b4).
⚠️ Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
hatchet/readers/caliper_native_reader.py 5.00% 17 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #173      +/-   ##
===========================================
- Coverage    61.45%   61.22%   -0.24%     
===========================================
  Files           49       49              
  Lines         5046     5065      +19     
  Branches      1205     1210       +5     
===========================================
  Hits          3101     3101              
- Misses        1707     1722      +15     
- Partials       238      242       +4     
Files with missing lines Coverage Δ
hatchet/readers/caliper_native_reader.py 81.76% <5.00%> (-4.84%) ⬇️

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status-ready-for-review This PR is ready to be reviewed by assigned reviewers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants