Skip to content

Conversation

@slabasan
Copy link
Collaborator

@slabasan slabasan commented Dec 21, 2025

Default to true. Order nodes using caliper's node ordering, which records the order in which functions are called (rather than by alphabetical frame ordering).

Note to review setting node_ordering=False if the appropriate metric is not in the caliper file (otherwise, have to explicitly turn off node_ordering when calling the reader.

@slabasan slabasan force-pushed the optional-node-ordering branch 4 times, most recently from 7e0143e to ed2ffb4 Compare December 21, 2025 07:04
Default to true. Order nodes using caliper's node ordering, which records the
order in which functions are called (rather than by alphabetical frame
ordering).
@slabasan slabasan force-pushed the optional-node-ordering branch from ed2ffb4 to 6bbc7e9 Compare December 21, 2025 21:06
- add error check if want node ordering but file doesn't support it
- when creating the graph, don't overwrite the node ordering boolean
based on if caliper file has specific metric
- update both caliper reader and caliper native reader
@slabasan slabasan force-pushed the optional-node-ordering branch from a60258d to af4f8b6 Compare December 23, 2025 05:57
@slabasan slabasan force-pushed the optional-node-ordering branch from d91e09e to d7511db Compare December 23, 2025 06:08
@slabasan slabasan merged commit 3168d5a into develop Dec 23, 2025
5 checks passed
@slabasan slabasan deleted the optional-node-ordering branch December 23, 2025 06:12
@codecov-commenter
Copy link

Codecov Report

❌ Patch coverage is 64.70588% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 61.21%. Comparing base (4f599be) to head (d7511db).
⚠️ Report is 2 commits behind head on develop.

Files with missing lines Patch % Lines
hatchet/readers/caliper_native_reader.py 40.00% 6 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #174      +/-   ##
===========================================
- Coverage    61.45%   61.21%   -0.24%     
===========================================
  Files           49       49              
  Lines         5046     5067      +21     
  Branches      1205     1212       +7     
===========================================
+ Hits          3101     3102       +1     
- Misses        1707     1723      +16     
- Partials       238      242       +4     
Files with missing lines Coverage Δ
hatchet/graphframe.py 78.89% <100.00%> (ø)
hatchet/readers/caliper_reader.py 83.92% <100.00%> (+0.07%) ⬆️
hatchet/readers/caliper_native_reader.py 81.23% <40.00%> (-5.38%) ⬇️

... and 3 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants