Skip to content

Add option to build without MFEM #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ckendrick wants to merge 5 commits into from
Closed

Add option to build without MFEM #26

ckendrick wants to merge 5 commits into from

Conversation

@ckendrick
Copy link
Collaborator

@ckendrick ckendrick commented Jun 6, 2024

This modifies setup.py to add a --no-mfem and --use-mfem option to control whether to compile pylibROM with MFEM enabled. To compile without MFEM, python setup.py install --no-mfem.

@ckendrick ckendrick added the WIP Work in progress label Jun 6, 2024
@chldkdtn
Copy link
Collaborator

chldkdtn commented Sep 14, 2024

Is it still work in progress?

@ckendrick ckendrick marked this pull request as ready for review September 26, 2024 15:45
@ckendrick ckendrick added RFR Ready for review and removed WIP Work in progress labels Sep 26, 2024
@ckendrick
Copy link
Collaborator Author

ckendrick commented Dec 17, 2024

Closed as this is part of #29.

@ckendrick ckendrick closed this Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

RFR Ready for review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ckendrick @chldkdtn