WIP: Refactor config toml SG #107
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New Jkl and crosskerr format:
Jkl = { "0-1" = <J01>, "3-5"=<val>, ...}
Remove collapse_type, instead use inline table for decoherence, containing its type, and the decay and decoherence types.
tdrwenski
reviewed
Dec 19, 2025
Collaborator
tdrwenski
left a comment
tdrwenski
left a comment
There was a problem hiding this comment.
I like the decoherence and optim_tolerance changes! That setting update and the code changes look good. I'm not sure about crosskerr/Jkl-- see other comment.
| Jkl = [0.0] | ||
| # Cross-kerr coupling strength for oscillators k<->l ("\xi_kl", multiplying a_k^d a_k a_l^d a_l, GHz). | ||
| # Format: table with keys "k-l" (e.g., "0-1") specifying coupling between oscillators k and l. Unspecified couplings default to zero. E.g. { "0-1" = <val>, "2-4" = <val>} | ||
| crosskerr = { "0-1" = 0.1 } |
Collaborator
There was a problem hiding this comment.
I still prefer not to put oscillator indexes into the toml keys. Keys should identify which thing you're configuring, not describe the contents of that thing. And you can't make the key an integer (it must be a string), so by putting the oscillator indexes there you add an extra string parsing step.
How about something like this:
crosskerr = [
{ oscillators = [0, 1], value = 0.1 },
{ oscillators = [1, 2], value = 0.05 }
]
This removes two toml configuration options: * optim_penalty * optim_penalty_param And instead adds three new options to replace them: * optim_penalty_leakage * optim_penalty_weightedcost * optim_penalty_weightedcost_width Before this change, the leakage term and the weighted running cost term were both controlled by the same option (optim_penalty). Now, those options can be specified separately. Their calculation in the timestepper is also split up into two separate functions. Naming of those functions and their treatment in the optimization problem is improved.
Multiple control segments for one oscillator are no longer supported.
Ensures backward compatibility with old cfg files using 'pure'.
Adds a testcase for reading cnot from file. Verified with main branch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.