Rework lesson 05 #47
Merged
Rework lesson 05 #47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
In the past, Arturo and I tried to make sure that lessons (with the TODO comments and code missing) still compiled so that it was easier to work through the lessons step by step and building along the way to check correctness. This lesson won't compile as-is... we used a Also, we should add a note about compiling with OpenMP turned on. Up until this point, openmp was not a dependency. Maybe including a cmake build command in the README? |
Member
Author
Member
Author
|
This PR is good to merge. Please review. Thank you. |
Member
|
@rchen20 , do you have some time to review and merge? |
artv3
approved these changes
Jul 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on our meeting last week, this is what I had in mind for intro lesson 5. Note that it the README is about the same length as the original original, the work for the participants to do is similar (although it actually gives them a working version to look at), and it allows them to compare results of a reduction sequential vs. parallel.