Updating lesson 3 #49
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhornung67
reviewed
Jul 10, 2025
rhornung67
reviewed
Jul 10, 2025
|
|
||
| // TODO: uncomment this print statement | ||
| //std::cout << "Allocated " << (100 * sizeof(double)) << " bytes and set to " | ||
| // << data[0] << " using the " << allocator.getName() << " allocator." |
Member
There was a problem hiding this comment.
Using memset to set an array of values to '0' and printing out the first value may not be convincing to some since sometimes memory allocations are initialized to zero by default. What do you think of doing an example like this https://www.geeksforgeeks.org/cpp/memset-in-cpp/ or something similar where the value is more convincing?
rhornung67
reviewed
Jul 10, 2025
| // TODO: uncomment this print statement | ||
| //std::cout << "Allocated " << (100 * sizeof(double)) << " bytes and set to " | ||
| // << data[0] << " using the " << allocator.getName() << " allocator." | ||
| // << std::endl; |
Member
There was a problem hiding this comment.
Also, what do you think about doing a realloc operation after the memset that grows the array and then show that the values set by memset are preserved, but the new array entries are uninitialized? I think it would make the example more interesting.
Member
|
Review and merge... |
artv3
approved these changes
Jul 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating lesson 3 to also include memset operator