Tupek/gretl cmake #1511
Closed
Tupek/gretl cmake #1511
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chapman39
approved these changes
Dec 16, 2025
Collaborator
chapman39
left a comment
chapman39
left a comment
There was a problem hiding this comment.
this looks good to me
white238
reviewed
Dec 16, 2025
Comment on lines
570
to
572
| set(GRETL_SOURCE_DIR "${PROJECT_SOURCE_DIR}/gretl" CACHE PATH "") | ||
|
|
||
| if (NOT EXISTS "${GRETL_SOURCE_DIR}/CMakeLists.txt") | ||
| message(FATAL_ERROR | ||
| "The gretl repo is not present. " | ||
| "Either run the following command in your git repository: \n" | ||
| " git submodule update --init --recursive\n" | ||
| "Or add -DGRETL_SOURCE_DIR=/path/to/gretl to your CMake command." ) | ||
| set(GRETL_SOURCE_DIR "${PROJECT_SOURCE_DIR}/smith/gretl" CACHE PATH "" FORCE) |
Member
There was a problem hiding this comment.
I think something like this would be cleaner:
if(NOT DEFINED GRETL_SOURCE_DIR)
set(GRETL_SOURCE_DIR "${PROJECT_SOURCE_DIR}/gretl" CACHE PATH "")
endif()
// then error if ${GRETL_SOURCE_DIR}/CMakeLists.txt doesnt exist
Collaborator
Author
There was a problem hiding this comment.
I think I cleaned it up a bit in the latest commit, but I still needed to try looking in /smith/gretl in some cases
tupek2
force-pushed
the
tupek/gretl_cmake
branch
from
2c41e07 to
1c18314
Compare
btalamini
approved these changes
Dec 18, 2025
tupek2
force-pushed
the
tupek/gretl_cmake
branch
2 times, most recently
from
99a270d to
a6791cf
Compare
tupek2
force-pushed
the
tupek/gretl_cmake
branch
from
a6791cf to
2e1b3d5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this enables smith to be built by other projects containing smith as a submodule