Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
For testing I am looking at:
Noh-RZ planar collapse (converging on the y-axis)
cd tests/functional/Hydro/Noh spheral Noh-RZ.py --problem planar --hydroType SPH --compatibleEnergy False spheral Noh-RZ.py --problem planar --hydroType SPH --compatibleEnergy True spheral Noh-RZ.py --problem planar --hydroType FSISPH --solid True --compatibleEnergy False spheral Noh-RZ.py --problem planar --hydroType FSISPH --solid True --compatibleEnergy TrueNoh-RZ cylindrical collapse (converging on the x-axis)
cd tests/functional/Hydro/Noh spheral Noh-RZ.py --problem cylindrical --hydroType SPH --compatibleEnergy False spheral Noh-RZ.py --problem cylindrical --hydroType SPH --compatibleEnergy True spheral Noh-RZ.py --problem cylindrical --hydroType FSISPH --solid True --compatibleEnergy False spheral Noh-RZ.py --problem cylindrical --hydroType FSISPH --solid True --compatibleEnergy TrueNoh-RZ spherical collapse (converging on the origin)
cd tests/functional/Hydro/Noh spheral Noh-RZ.py --problem spherical --hydroType SPH --compatibleEnergy False spheral Noh-RZ.py --problem spherical --hydroType SPH --compatibleEnergy True spheral Noh-RZ.py --problem spherical --hydroType FSISPH --solid True --compatibleEnergy False spheral Noh-RZ.py --problem spherical --hydroType FSISPH --solid True --compatibleEnergy TrueVerney shell implosion. This one gives you some tests of the strength and plastic response which the Noh problem does not.
cd tests/functional/Strength/Verney spheral Verney-RZ.py --hydroType SPH --compatibleEnergy False --evolveTotalEnergy False spheral Verney-RZ.py --hydroType SPH --compatibleEnergy True --evolveTotalEnergy False spheral Verney-RZ.py --hydroType FSISPH --compatibleEnergy False --evolveTotalEnergy False spheral Verney-RZ.py --hydroType FSISPH --compatibleEnergy True --evolveTotalEnergy FalseToDo :
RELEASE_NOTES.mdwith notable changes.