-
Notifications
You must be signed in to change notification settings - Fork 9
Unit Test for node_ordering Setting #236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
slabasan
merged 9 commits into
llnl:develop
from
michaelmckinsey1:multi-profile-node_ordering
Jul 1, 2025
Merged
Unit Test for node_ordering Setting #236
slabasan
merged 9 commits into
llnl:develop
from
michaelmckinsey1:multi-profile-node_ordering
Jul 1, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
This PR was mentioned in #237 by mistake |
Collaborator
Author
|
depends on llnl/hatchet#154 |
07c291e to
5ccab7c
Compare
Collaborator
Author
|
This one ready since llnl/hatchet#154 merged |
5ccab7c to
2d30adc
Compare
2d30adc to
a0c45b0
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #236 +/- ##
===========================================
+ Coverage 83.06% 83.09% +0.02%
===========================================
Files 65 65
Lines 4452 4459 +7
===========================================
+ Hits 3698 3705 +7
Misses 754 754
🚀 New features to boost your workflow:
|
slabasan
approved these changes
Jul 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area-tests
Issues and PRs involving Thicket's automated tests
priority-normal
Normal priority issues and PRs
status-ready-for-review
This PR is ready to be reviewed by assigned reviewers
type-bug
Identifies bugs in issues and identifies bug fixes in PRs
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was discovered from hatchet#154, that
node_orderingwas being set toFalse, after callingGraph.union()which happens inEnsemble.unify(). This PR adds unit tests for the node ordering setting for Thickets with more than one profile.