Skip to content

Conversation

@michaelmckinsey1
Copy link
Collaborator

@michaelmckinsey1 michaelmckinsey1 commented Jan 22, 2025

It was discovered from hatchet#154, that node_ordering was being set to False, after calling Graph.union() which happens in Ensemble.unify(). This PR adds unit tests for the node ordering setting for Thickets with more than one profile.

@michaelmckinsey1 michaelmckinsey1 added area-tests Issues and PRs involving Thicket's automated tests priority-normal Normal priority issues and PRs status-ready-for-review This PR is ready to be reviewed by assigned reviewers type-bug Identifies bugs in issues and identifies bug fixes in PRs labels Jan 22, 2025
@michaelmckinsey1 michaelmckinsey1 self-assigned this Jan 22, 2025
@michaelmckinsey1
Copy link
Collaborator Author

This PR was mentioned in #237 by mistake

@michaelmckinsey1
Copy link
Collaborator Author

depends on llnl/hatchet#154

@michaelmckinsey1
Copy link
Collaborator Author

This one ready since llnl/hatchet#154 merged

@michaelmckinsey1 michaelmckinsey1 force-pushed the multi-profile-node_ordering branch from 5ccab7c to 2d30adc Compare May 20, 2025 23:13
@michaelmckinsey1 michaelmckinsey1 force-pushed the multi-profile-node_ordering branch from 2d30adc to a0c45b0 Compare June 30, 2025 23:58
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.09%. Comparing base (545af35) to head (a0c45b0).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #236      +/-   ##
===========================================
+ Coverage    83.06%   83.09%   +0.02%     
===========================================
  Files           65       65              
  Lines         4452     4459       +7     
===========================================
+ Hits          3698     3705       +7     
  Misses         754      754              
Files with missing lines Coverage Δ
thicket/tests/conftest.py 100.00% <100.00%> (ø)
thicket/tests/test_caliperreader.py 100.00% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@slabasan slabasan merged commit 291cbd2 into llnl:develop Jul 1, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-tests Issues and PRs involving Thicket's automated tests priority-normal Normal priority issues and PRs status-ready-for-review This PR is ready to be reviewed by assigned reviewers type-bug Identifies bugs in issues and identifies bug fixes in PRs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants