Skip to content

Update Statsframe Graph after DataFrame Squash #263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
slabasan merged 2 commits into from
Dec 21, 2025
Merged

Update Statsframe Graph after DataFrame Squash #263

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
880ce44
Update thicket.py
michaelmckinsey1 Aug 20, 2025
c754c2e
Add check
michaelmckinsey1 Aug 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions thicket/tests/test_filter_stats.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,9 @@ def check_filter_stats(th, columns_values):
# We can't check th.graph because of squash in filter_stats
assert th.statsframe.graph is not new_th.statsframe.graph

# Check Thicket and Statsframe graph in sync
assert len(new_th.graph) == len(new_th.statsframe.graph)

# filtered nodes in aggregated statistics table
stats_nodes = sorted(
new_th.statsframe.dataframe.index.drop_duplicates().tolist()
Expand Down
3 changes: 3 additions & 0 deletions thicket/thicket.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1662,7 +1662,10 @@ def filter_stats(self, filter_function):
]

# filter nodes in the graphframe based on the dataframe nodes
# We want to preserve columns, so "new_statsframe=False",
# however to match graph filter we update statsframe.graph
new_thicket = new_thicket.squash(new_statsframe=False)
new_thicket.statsframe.graph = new_thicket.graph

return new_thicket

Expand Down
Loading