Adds support for Hatchet's "new-style" queries to Thicket #44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilumsden
added
area-query-lang
ilumsden
force-pushed
the
new-style-queries
branch
3 times, most recently
from
62a4273 to
f47a65a
Compare
ilumsden
force-pushed
the
new-style-queries
branch
from
4554cee to
7a16206
Compare
slabasan
approved these changes
Jun 15, 2023
Collaborator
slabasan
left a comment
slabasan
left a comment
There was a problem hiding this comment.
Looks good, but I see it is still in draft mode. Is this ready for merge?
Collaborator
|
@ilumsden Let me know if this one is no longer in draft mode. |
Collaborator
Author
|
@slabasan there are still some things I need to fix to get things passing with unit tests. I also realized that this will only get the dialects working for Thickets without a column multi-index. That means things like columnar join Thickets aren't going to be supported yet. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for Hatchet's new-style queries to Thicket. More specifically, this PR adds the following:
thicket.querymodule that re-exports the Query Language classes and functionsThe dialect support is enabled through the new
multi_index_modeparameter. This parameter is currently being documented in llnl/hatchet#90.