Add SparseStore support to umapsort #26
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karimyoussef91
force-pushed
the
feature/umapsort_sparse_store
branch
from
8f8d994 to
7648c50
Compare
| if (uunmap(region, numbytes) < 0) { | ||
| std::ostringstream ss; | ||
| ss << "uunmap of failure: "; | ||
| perror(ss.str().c_str()); |
Member
There was a problem hiding this comment.
Is this needed here?
perror("uunmap of failure: ");
| delete store; | ||
| exit(-1); | ||
| } | ||
| delete store; |
Member
There was a problem hiding this comment.
Are the 2 forms the same here?
if(){
delete store
}
delete store
==
delete store
if(){
}
Member
asarkar-parsys
left a comment
asarkar-parsys
left a comment
There was a problem hiding this comment.
Can you address the minor comments?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a feature to the umapsort benchmark that enables the use of UMap with a sparse multi-file backing store interface.