Fix install path of Variorum cmake files #589
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I would like to propose updating the path of installation of Variorum cmake files. I have tried to find the library using
CMAKE_PREFIX_PATHandVariorum_ROOTbut both variables could not make CMake find the library. Only specifyingVariorum_DIRto the actual location ofVariorumConfig.cmakeworked. This is a problem for a package manager like Spack as it is relying onCMAKE_PREFIX_PATH.My understanding is that the cmake search procedure, see https://cmake.org/cmake/help/latest/command/find_package.html#config-mode-search-procedure, cannot find VariorumConfig.cmake where it is currently installed.
With the change of the PR, I could correctly find the library with
CMAKE_PREFIX_PATHandVariorum_ROOT.Fixes #
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please provide hardware architecture specs and
instructions so we can reproduce.
Checklist:
./scripts/check-code-format.shand confirm my code code follows the style guidelines of variorum-DENABLE_WARNINGS=ON)Thank you for taking the time to contribute to Variorum!