Skip to content

Conversation

@tpadioleau
Copy link
Contributor

@tpadioleau tpadioleau commented Oct 3, 2025

Description

I would like to propose updating the path of installation of Variorum cmake files. I have tried to find the library using CMAKE_PREFIX_PATH and Variorum_ROOT but both variables could not make CMake find the library. Only specifying Variorum_DIR to the actual location of VariorumConfig.cmake worked. This is a problem for a package manager like Spack as it is relying on CMAKE_PREFIX_PATH.

My understanding is that the cmake search procedure, see https://cmake.org/cmake/help/latest/command/find_package.html#config-mode-search-procedure, cannot find VariorumConfig.cmake where it is currently installed.

With the change of the PR, I could correctly find the library with CMAKE_PREFIX_PATH and Variorum_ROOT.

Fixes #

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature/architecture support (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Build/CI update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please provide hardware architecture specs and
instructions so we can reproduce.

  • Test A: Hardware architecture, machine name, example/test run
  • Test B: Hardware architecture, machine name, example/test run
  • ...

Checklist:

  • I have run ./scripts/check-code-format.sh and confirm my code code follows the style guidelines of variorum
  • I have added comments in my code
  • My changes generate no new warnings (build with -DENABLE_WARNINGS=ON)
  • New and existing unit tests pass with my changes

Thank you for taking the time to contribute to Variorum!

Copy link
Contributor

@masterleinad masterleinad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me.

@slabasan slabasan merged commit c3b620a into llnl:dev Oct 3, 2025
9 checks passed
Copy link
Collaborator

@slabasan slabasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

@tpadioleau tpadioleau deleted the fix-cmake-search-path branch October 4, 2025 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants