Feature/work_queue #386
Merged
Feature/work_queue #386
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed base_misc-inherited functions that do not fit current workqueue model, revised function names to fit YGM naming conventions, and added lifo queue policy
…ts to prevent compiler warnings
Collaborator
|
This all looks good. I thought a little more about a new place to put this code, but I think |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creates a templated workqueue structure for YGM applications and provides FIFO, LIFO, and priority policies for queue ordering. Current implementation supports one lambda to be run for all items that are inserted into the queue.
Work items are processed in batches (all items currently in queue will be processed) at barriers by a helper function via comm::register_pre_barrier_callback or manually via local_process_all. There is no support for individual execution at this time.
Future directions may include more granular execution policies and a way to enqueue work lambdas alongside work items.
Test suite to ensure intended behavior for all queue types.