Skip to content

Conversation

@vicentebolea
Copy link
Collaborator

@vicentebolea vicentebolea commented Mar 13, 2025

This moves the windows build from Appveyor to Github.

IT now tests with:

  • VS 16 2019 32b and 64b.
  • VS 17 2022 32b and 64b
  • Mingw 64b

@vicentebolea vicentebolea force-pushed the move-win-builds-gha branch 27 times, most recently from 45df445 to 5f1f09b Compare March 14, 2025 20:24
@vicentebolea
Copy link
Collaborator Author

@lindstro I can see that the appveyor jobs split the builds into two: One with OpenMP and one with cfp2. Are these opts mutually exclusive? Can we set them ON at the same time?

Thanks!

@vicentebolea vicentebolea force-pushed the move-win-builds-gha branch 2 times, most recently from e51c09f to 58e5233 Compare March 14, 2025 20:44
@vicentebolea vicentebolea force-pushed the move-win-builds-gha branch 17 times, most recently from 19f729b to f66e9cc Compare March 14, 2025 23:35
@vicentebolea vicentebolea requested a review from lindstro March 14, 2025 23:35
@vicentebolea vicentebolea self-assigned this Mar 14, 2025
@vicentebolea vicentebolea force-pushed the move-win-builds-gha branch 3 times, most recently from cb5b416 to dc113bf Compare March 14, 2025 23:55
@lindstro
Copy link
Member

@lindstro I can see that the appveyor jobs split the builds into two: One with OpenMP and one with cfp2. Are these opts mutually exclusive? Can we set them ON at the same time?

I believe we decided to split jobs up a very long time ago, perhaps because of Travis (?) time limits that we sometimes exceeded. I can't think of any good reason to do so with our current test environment, however.

Copy link
Member

@lindstro lindstro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lindstro lindstro merged commit 6d8334c into llnl:staging Mar 15, 2025
11 checks passed
@vicentebolea vicentebolea deleted the move-win-builds-gha branch March 15, 2025 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants