[FIRRTL] LowerLayers: Update innerrefs in extracted verbatim's #8094
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seldridge
approved these changes
Jan 17, 2025
| @@ -699,6 +703,18 @@ LogicalResult LowerLayersPass::runOnModuleBody(FModuleOp moduleOp, | |||
| hw::InnerRefAttr::get(mapped->second.second, targetRef.getName())); | |||
| } | |||
|
|
|||
| // Update verbatims that target operations extracted alongside. | |||
| mlir::AttrTypeReplacer replacer; | |||
There was a problem hiding this comment.
I wasn't aware of this. Nice.
This continues to not address lack of global updating, but fixes use of verbatims that are extracted along with their targets.
dtzSiFive
force-pushed
the
feature/lower-layers-verbatim-innerref
branch
from
2edaba6 to
d83fd12
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This continues to not address lack of global updating, but fixes use of verbatims that are extracted along with their targets.