[HWToBTOR2] Support unary case of variadics #9169
Open
+17
−7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for the case where a variadic op has only one operand by just forwarding future LID lookups of that op to the LID of the operand. There's also a tweak to some value names in the comb HWToBTOR2 test to avoid the faff of incrementing the names every time more NIDs are added.
I don't think there's any need to check for the nullary case since, based on a bit of testing, nullary comb variadics shouldn't be valid since there's no valid result type that can be derived, but if that's not the case then I'll add a check!