[FIRRTL] Add anonymous domain create op #9296
Open
+58
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add an anonymous domain create operation. This is used to model domains that are fully self-contained within a FIRRTL circuit and are not reachable from any external port. Signed-off-by: Schuyler Eldridge <[email protected]>
dtzSiFive
approved these changes
Dec 3, 2025
Contributor
dtzSiFive
left a comment
dtzSiFive
left a comment
There was a problem hiding this comment.
Thanks for this! Generally looks great, left some feedback.
| } | ||
|
|
||
| def DomainCreateAnonOp : FIRRTLOp<"domain.anon", [ | ||
| ParentOneOf<["firrtl::FModuleOp", "firrtl::LayerBlockOp"]>, |
Member
Author
There was a problem hiding this comment.
Good catch. I'm going to use the same parents as HardwareDeclOp, but not use that tablegen class as it pulls in a requirement that these have a name. Fixed in: 6fd1f85
rwy7
approved these changes
Dec 3, 2025
Contributor
|
Maybe FIRRTL Emitter needs touching, probably just skip these operations? |
Member
Author
Yes, just dropping these is the right thing. I'll take a look at that shortly... This may be kind of weird as these could get routed through wires. However, I think the right thing is to drop both the anonymous domain and any domain define user. WDYT? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an anonymous domain create operation. This is used to model domains
that are fully self-contained within a FIRRTL circuit and are not
reachable from any external port.