Skip to content

[CIR][HIP] Use GlobalView to access stub #1957

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

[CIR][HIP] Use GlobalView to access stub #1957

wants to merge 4 commits into from
+46 −11

Conversation

@koparasy
Copy link
Contributor

No description provided.

@koparasy koparasy changed the title Use GlobalView to access stub [CIR][HIP] Use GlobalView to access stub Oct 27, 2025
@bcardosolopes
Copy link
Member

Seems like Clang :: CIR/CodeGen/HIP/simple.cpp is failing, but LGTM once it gets green!

@koparasy
Copy link
Contributor Author

Seems like Clang :: CIR/CodeGen/HIP/simple.cpp is failing, but LGTM once it gets green!

This is strange to me, I need to investigate it locally.

@koparasy
Copy link
Contributor Author

@bcardosolopes Ok. LLVM device code generation is not support yet on HIP. I removed that part of the test. Will add ABI as a separate PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bcardosolopes bcardosolopes bcardosolopes approved these changes

@lanza lanza Awaiting requested review from lanza lanza is a code owner

@xlauko xlauko Awaiting requested review from xlauko xlauko is a code owner

@andykaylor andykaylor Awaiting requested review from andykaylor andykaylor is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@koparasy @bcardosolopes