Address code review comments

Author: AmrDeveloper

clang/lib/CIR/Dialect/IR/CIRDialect.cpp

@@ -1593,10 +1593,9 @@ OpFoldResult cir::VecCmpOp::fold(FoldAdaptor adaptor) {
   auto lhsVecAttr = mlir::cast<cir::ConstVectorAttr>(lhs);
   auto rhsVecAttr = mlir::cast<cir::ConstVectorAttr>(rhs);
 
-  auto inputElemTy =
+  mlir::Type inputElemTy =
       mlir::cast<cir::VectorType>(lhsVecAttr.getType()).getElementType();
-  if (!mlir::isa<cir::IntType>(inputElemTy) &&
-      !mlir::isa<cir::CIRFPTypeInterface>(inputElemTy))
+  if (!isAnyIntegerOrFloatingPointType(inputElemTy))
     return {};
 
   cir::CmpOpKind opKind = adaptor.getKind();

clang/lib/CIR/Dialect/Transforms/CIRCanonicalize.cpp

@@ -141,8 +141,8 @@ void CIRCanonicalizePass::runOnOperation() {
 
     // Many operations are here to perform a manual `fold` in
     // applyOpPatternsGreedily.
-    if (isa<BrOp, BrCondOp, CastOp, ScopeOp, SwitchOp, SelectOp, UnaryOp,
-            VecExtractOp, VecShuffleDynamicOp, VecTernaryOp, VecCmpOp>(op))
+    if (isa<BrCondOp, BrOp, CastOp, ScopeOp, SelectOp, SwitchOp, UnaryOp,
+            VecCmpOp, VecExtractOp, VecShuffleDynamicOp, VecTernaryOp>(op))
       ops.push_back(op);
   });