HeuristicResolver incorrectly applies const-checking to static methods called through an instance

[HighCommander4]

In the following code:

template <typename T>
struct Waldo {
  static void find();
};

template <typename T>
void foo(const Waldo<T>& t) {
  t.find();
}

HeuristicResolver fails to resolve the call to t.find() to Waldo::find() because it's applying const-checking even though that doesn't apply to static methods (even if you call them through an instance, as in this example).

[HighCommander4]

This is a regression from #123551.

[llvmbot]

@llvm/issue-subscribers-clang-frontend

Author: Nathan Ridge (HighCommander4)

In the following code:

template <typename T>
struct Waldo {
  static void find();
};

template <typename T>
void foo(const Waldo<T>& t) {
  t.find();
}

HeuristicResolver fails to resolve the call to t.find() to Waldo::find() because it's applying const-checking even though that doesn't apply to static methods (even if you call them through an instance, as in this example).

[HighCommander4]

Proposed fix: #125166