[clang][unittest] BasicTests fail to link #174513
Merged
+1
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DarwinSDKInfo.PlatformPrefix adds use of Triple but failed to add a link to LLVMTargetParser, add that.
Member
|
@llvm/pr-subscribers-clang Author: Ian Anderson (ian-twilightcoder) ChangesDarwinSDKInfo.PlatformPrefix adds use of Triple but failed to add a link to LLVMTargetParser, add that. Full diff: https://github.com/llvm/llvm-project/pull/174513.diff 1 Files Affected:
diff --git a/clang/unittests/Basic/CMakeLists.txt b/clang/unittests/Basic/CMakeLists.txt
index f20c8db00a595..4918d07ace22b 100644
--- a/clang/unittests/Basic/CMakeLists.txt
+++ b/clang/unittests/Basic/CMakeLists.txt
@@ -16,6 +16,7 @@ add_distinct_clang_unittest(BasicTests
clangBasic
clangLex
LINK_LIBS
+ LLVMTargetParser
LLVMTestingSupport
LLVM_COMPONENTS
Support
|
Contributor
|
Thanks for the fix. I tested locally and the "undefined reference" error has gone. |
mahesh-attarde
pushed a commit
to mahesh-attarde/llvm-project
that referenced
this pull request
Jan 6, 2026
DarwinSDKInfo.PlatformPrefix adds use of Triple but failed to add a link to LLVMTargetParser, add that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DarwinSDKInfo.PlatformPrefix adds use of Triple but failed to add a link to LLVMTargetParser, add that.