Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[onnx] Convert resources to denseattr for onnx.constant to torch #2830

Merged
merged 3 commits into from
Jan 31, 2024
Merged

[onnx] Convert resources to denseattr for onnx.constant to torch #2830

merged 3 commits into from
Jan 31, 2024

Conversation

rsuderman
Copy link
Contributor

@rsuderman rsuderman commented Jan 30, 2024 •
edited
Loading

onnx explicitly specifies that raw_data is stored in little-endian layout. While converting
to torch we need to convert from a known endian format to an internal format of consistent
layout. This means endianness must be correct during the import of onnx.Constant.

@renxida
Update DefaultDomainAtoF.cpp
d88183b 
typo on big endian error message
renxida
renxida approved these changes Jan 31, 2024
View reviewed changes
Copy link
Collaborator

@renxida renxida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. fixed minor typo.

@renxida renxida mentioned this pull request Jan 31, 2024
Open
@rsuderman rsuderman merged commit 3500523 into llvm:main Jan 31, 2024
3 checks passed
@rsuderman rsuderman deleted the onnx_resources branch January 31, 2024 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@renxida renxida renxida approved these changes

@stellaraccident stellaraccident Awaiting requested review from stellaraccident

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rsuderman @renxida