[TOSA] Fix empty-dim reductions #4365
Open
+87
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Teach the TorchToTosa reducer that an explicit empty dim list means "all dims" and cast the result back to the requested dtype. Add MLIR and e2e regression cases and update XFAILs. Change-Id: Ibd1be38d219ad5c1986eb4a641efbb9ff0cb6a55
Contributor
Author
|
Reviewed. Looks good to me. |
sahas3
approved these changes
Nov 19, 2025
| } | ||
|
|
||
| // Ensure the result element type matches the expected output type. | ||
| if (val.getType() != output_type) { |
Member
There was a problem hiding this comment.
Clarification: In what scenarios will this happen? From the added LIT test it seems that this cast wasn't necessary.
| // ----- | ||
|
|
||
| // CHECK-LABEL: func.func @test_reduce_sum_empty_dims$basic( | ||
| // CHECK-SAME: %[[VAL_0:.*]]: !torch.vtensor<[2,3,4],f32>) -> !torch.vtensor<[],f32> { |
Member
There was a problem hiding this comment.
It'll be nice to update the variable names similar to the other PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Teach the TorchToTosa reducer that an explicit empty dim list means "all dims" and cast the result back to the requested dtype. Add MLIR and e2e regression cases and update XFAILs.