fix: refactor Novelfire popularNovels and fix summary - #2100
Conversation
81bb639 to
6aff4b5
Compare
|
So, when does this change get reflected in the actual plugin? |
|
when status change from open to merged |
|
I am new to this so if I may ask: how long can it take for the status to change since the fix is already there and I don't think there's much the devs have to to on their end now right? |
|
just waiting on the maintainer to merge, not sure when merge |
|
Got it, thanks! |
|
One more thing I noticed is that some novels have suddenly become paginated with for example: 1 - 80 chapters on page 1 then above 80 it directly jumps to the final chapter numbers, I.e. 1100 to 1220 something on that same page while pages 2, 3, 4 etc get 50 or so chapters from in between those. Why is this happening and only to some of my novels on novel fire. For your reference, the novel I am talking about is Hail the King. |
Holy shit edge case, I gotta fix rhis |
After looking into this for a bit, it looks ok? Make a git issue with pics as I am unable to replicate |
|
Using the force load setting 'hail the king' (has 1635 chapters) first showed 1550 chapters then after refreshing it showed 1635 chapters |
|
Now I think it is fixed but it still sometimes when in the library gets changed to paginated then after refreshing gets force loaded into one. Lmao, I don't know what to say now. |
* fix: change novel.totalPages calculation to divide by 50 instead of 100 * update version number * fix: refactor novelfire popular,search and summary --------- Co-authored-by: G0yp <goupsoup2@gmail.com>
Checklist
Closes #2094
Closes #2097