Skip to content

fix: refactor Novelfire popularNovels and fix summary - #2100

Merged
rajarsheechatterjee merged 3 commits into
lnreader:masterfrom
K1ngfish3r:novelfire
Apr 7, 2026
Merged

fix: refactor Novelfire popularNovels and fix summary#2100
rajarsheechatterjee merged 3 commits into
lnreader:masterfrom
K1ngfish3r:novelfire

Conversation

@K1ngfish3r

@K1ngfish3r K1ngfish3r commented Apr 3, 2026

Copy link
Copy Markdown
Collaborator

Checklist

  • Update version code if an existing plugin was modified
  • Test changes in Plugin Playground or the app
  • Reference related issues in the PR body (e.g. Closes #xyz)

Closes #2094
Closes #2097

@K1ngfish3r
K1ngfish3r force-pushed the novelfire branch 2 times, most recently from 81bb639 to 6aff4b5 Compare April 6, 2026 12:07
@Seuhen

Seuhen commented Apr 6, 2026

Copy link
Copy Markdown

So, when does this change get reflected in the actual plugin?

@K1ngfish3r

Copy link
Copy Markdown
Collaborator Author

when status change from open to merged

@Seuhen

Seuhen commented Apr 6, 2026

Copy link
Copy Markdown

I am new to this so if I may ask: how long can it take for the status to change since the fix is already there and I don't think there's much the devs have to to on their end now right?

@K1ngfish3r

Copy link
Copy Markdown
Collaborator Author

just waiting on the maintainer to merge, not sure when merge

@Seuhen

Seuhen commented Apr 6, 2026

Copy link
Copy Markdown

Got it, thanks!

@Seuhen

Seuhen commented Apr 7, 2026

Copy link
Copy Markdown

One more thing I noticed is that some novels have suddenly become paginated with for example: 1 - 80 chapters on page 1 then above 80 it directly jumps to the final chapter numbers, I.e. 1100 to 1220 something on that same page while pages 2, 3, 4 etc get 50 or so chapters from in between those. Why is this happening and only to some of my novels on novel fire. For your reference, the novel I am talking about is Hail the King.

@rajarsheechatterjee
rajarsheechatterjee merged commit a3cf999 into lnreader:master Apr 7, 2026
1 check passed
@K1ngfish3r

Copy link
Copy Markdown
Collaborator Author

One more thing I noticed is that some novels have suddenly become paginated with for example: 1 - 80 chapters on page 1 then above 80 it directly jumps to the final chapter numbers, I.e. 1100 to 1220 something on that same page while pages 2, 3, 4 etc get 50 or so chapters from in between those. Why is this happening and only to some of my novels on novel fire. For your reference, the novel I am talking about is Hail the King.

Holy shit edge case, I gotta fix rhis

@K1ngfish3r

Copy link
Copy Markdown
Collaborator Author

One more thing I noticed is that some novels have suddenly become paginated with for example: 1 - 80 chapters on page 1 then above 80 it directly jumps to the final chapter numbers, I.e. 1100 to 1220 something on that same page while pages 2, 3, 4 etc get 50 or so chapters from in between those. Why is this happening and only to some of my novels on novel fire. For your reference, the novel I am talking about is Hail the King.

After looking into this for a bit, it looks ok? Make a git issue with pics as I am unable to replicate

@K1ngfish3r
K1ngfish3r deleted the novelfire branch April 7, 2026 03:03
@dreamingturtle21-debug

Copy link
Copy Markdown

Using the force load setting 'hail the king' (has 1635 chapters) first showed 1550 chapters then after refreshing it showed 1635 chapters

@Seuhen

Seuhen commented Apr 7, 2026

Copy link
Copy Markdown

Now I think it is fixed but it still sometimes when in the library gets changed to paginated then after refreshing gets force loaded into one. Lmao, I don't know what to say now.

nofzo pushed a commit to nofzo/lnreader-plugins that referenced this pull request May 22, 2026
* fix: change novel.totalPages calculation to divide by 50 instead of 100

* update version number

* fix: refactor novelfire popular,search and summary

---------

Co-authored-by: G0yp <goupsoup2@gmail.com>
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Jul 23, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Missing ch Filter feature not working properly

5 participants