NovelFire Empty Chapter fix - #2462
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the NovelFire multisrc plugin to treat empty/missing chapter content as a hard failure (via thrown errors), enabling the app to retry requests and mitigating intermittent “empty chapter / mixed chapter” load issues reported in #2460, #2459, #2456, and #2436.
Changes:
- Throw an explicit error when the chapter content container (
#content) is missing or when parsed chapter HTML is empty. - Minor refactor in the tag-filtering loop (reuse computed tag string).
- Bump NovelFire source
versionIncrementto release the fix.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| plugins/multisrc/novelfire/template.ts | Adds retry-triggering errors for missing/empty chapter content and adjusts chapter DOM cleanup logic. |
| plugins/multisrc/novelfire/sources.json | Increments plugin version to publish the change. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
463
to
465
| const tag = ele.name.toString(); | ||
| if (tag.length > 5 && ele.name.toString().substring(0, 1) == 'nf') { | ||
| if (tag.length > 5 && tag.substring(0, 1) == 'nf') { | ||
| loadedCheerio(ele).remove(); |
rajarsheechatterjee
approved these changes
Aug 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #2460 #2459 #2456 #2436
Plugin fails loudly in case of empty #content which allows the application to do a retry which fixes the mixing chapter issue.
Checklist