Fixed LibRead chapterlist not loading - #2463
Closed
D3ICIDE wants to merge 0 commit into
Closed
Conversation
Contributor
Author
|
Needs clarification on whether to version bump every plugin in the source or only the plugin that uses that part of the code. |
There was a problem hiding this comment.
Pull request overview
Fixes Lib Read chapter loading and updates its plugin version.
Changes:
- Prefer parsed chapter lists for non-AJAX sources.
- Bump Lib Read from version 2.2.3 to 2.2.4.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Summary |
|---|---|
plugins/multisrc/readnovelfull/template.ts |
Adjusts chapter-list selection logic. |
plugins/multisrc/readnovelfull/sources.json |
Updates Lib Read’s plugin version. |
Suppressed comments (1)
plugins/multisrc/readnovelfull/template.ts:502
- This template is shared by Free Web Novel as well as Lib Read. FWN.com also sets
noAjax: trueand configuresapi/chapterlist.phpinsources.json:86-97; when its page contains any parsed chapters, this branch now skips that API even iftotalChapteris populated. The previous condition used the API in that case, so a page/partial list can omit chapters. Make using the page list an explicit per-source option enabled only for Lib Read, or retain the API path for FWN.
if (this.options.noAjax && chapters.length > 0) {
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closed: #2452
Checklist