Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 fix: pin [email protected] to fix code highlight #4047

Merged
merged 1 commit into from
Sep 20, 2024
Merged

🐛 fix: pin [email protected] to fix code highlight #4047

merged 1 commit into from
Sep 20, 2024

Conversation

arvinxx
Copy link
Contributor

@arvinxx arvinxx commented Sep 20, 2024 •
edited
Loading

💻 变更类型 | Change Type

  • ✨ feat
  • 🐛 fix
  • ♻️ refactor
  • 💄 style
  • 👷 build
  • ⚡️ perf
  • 📝 docs
  • 🔨 chore

🔀 变更说明 | Description of Change

upgrade to [email protected] , we lost the highlight in code.

if downgrade to 1.17.7, it works well.

1.17.7 1.18.0
image image
https://lobe-chat-preview-1ft0sw5hj-lobehub-pro.vercel.app https://lobe-chat-preview-ftdrms5xe-lobehub-pro.vercel.app/

📝 补充信息 | Additional Information

refs: https://discord.com/channels/1127171173982154893/1286700039049183293

reproduce branch: https://github.com/lobehub/lobe-chat/tree/reproduction/shiki-1.18.0

@vercel Vercel
Copy link

vercel bot commented Sep 20, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lobe-chat-database ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 20, 2024 4:19pm
lobe-chat-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 20, 2024 4:19pm

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Sep 20, 2024
@lobehubbot
Copy link
Member

👍 @arvinxx

Thank you for raising your pull request and contributing to our Community
Please make sure you have followed our contributing guidelines. We will review it as soon as possible.
If you encounter any problems, please feel free to connect with us.
非常感谢您提出拉取请求并为我们的社区做出贡献，请确保您已经遵循了我们的贡献指南，我们会尽快审查它。
如果您遇到任何问题，请随时与我们联系。

@dosubot dosubot bot added the 🐛 Bug Something isn't working | 缺陷 label Sep 20, 2024
@codecov Codecov
Copy link

codecov bot commented Sep 20, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.73%. Comparing base (e960a23) to head (be71bfd).
Report is 323 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff            @@
##             main    #4047    +/-   ##
========================================
  Coverage   91.73%   91.73%            
========================================
  Files         481      481            
  Lines       34215    34215            
  Branches     2235     3147   +912     
========================================
  Hits        31388    31388            
  Misses       2827     2827
Flag Coverage Δ
app 91.73% <ø> (ø)
server 97.36% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@arvinxx arvinxx changed the title 🐛 fix: pin [email protected] to fix highlight issue 🐛 fix: pin [email protected] to fix code highlight Sep 20, 2024
@arvinxx arvinxx merged commit d12bf4c into main Sep 20, 2024
12 checks passed
@arvinxx arvinxx deleted the fix/highlight branch September 20, 2024 16:30
@lobehubbot
Copy link
Member

❤️ Great PR @arvinxx ❤️

The growth of project is inseparable from user feedback and contribution, thanks for your contribution! If you are interesting with the lobehub developer community, please join our discord and then dm @arvinxx or @canisminor1990. They will invite you to our private developer channel. We are talking about the lobe-chat development or sharing ai newsletter around the world.
项目的成长离不开用户反馈和贡献，感谢您的贡献! 如果您对 LobeHub 开发者社区感兴趣，请加入我们的 discord，然后私信 @arvinxx 或 @canisminor1990。他们会邀请您加入我们的私密开发者频道。我们将会讨论关于 Lobe Chat 的开发，分享和讨论全球范围内的 AI 消息。

github-actions bot pushed a commit that referenced this pull request Sep 20, 2024
@semantic-release-bot
🔖 chore(release): v1.19.14 [skip ci]
d0d5fe8 
### [Version&nbsp;1.19.14](v1.19.13...v1.19.14)
<sup>Released on **2024-09-20**</sup>

#### 🐛 Bug Fixes

- **misc**: Pin `[email protected]` to fix code highlight.

<br/>

<details>
<summary><kbd>Improvements and Fixes</kbd></summary>

#### What's fixed

* **misc**: Pin `[email protected]` to fix code highlight, closes [#4047](#4047) ([d12bf4c](d12bf4c))

</details>

<div align="right">

[![](https://img.shields.io/badge/-BACK_TO_TOP-151515?style=flat-square)](#readme-top)

</div>
@lobehubbot
Copy link
Member

🎉 This PR is included in version 1.19.14 🎉

The release is available on:

Your semantic-release bot 📦🚀

@arvinxx arvinxx mentioned this pull request Sep 20, 2024
Closed
5 tasks
github-actions bot pushed a commit to bentwnghk/lobe-chat that referenced this pull request Sep 20, 2024
@semantic-release-bot
🔖 chore(release): v1.62.4 [skip ci]
a595db6 
### [Version&nbsp;1.62.4](v1.62.3...v1.62.4)
<sup>Released on **2024-09-20**</sup>

#### 🐛 Bug Fixes

- **misc**: Pin `[email protected]` to fix code highlight, try to implement better ssrf-protect.

#### 💄 Styles

- **misc**: Improve i18n in discover.

<br/>

<details>
<summary><kbd>Improvements and Fixes</kbd></summary>

#### What's fixed

* **misc**: Pin `[email protected]` to fix code highlight, closes [lobehub#4047](https://github.com/bentwnghk/lobe-chat/issues/4047) ([d12bf4c](d12bf4c))
* **misc**: Try to implement better ssrf-protect, closes [lobehub#4044](https://github.com/bentwnghk/lobe-chat/issues/4044) ([e960a23](e960a23))

#### Styles

* **misc**: Improve i18n in discover, closes [lobehub#4049](https://github.com/bentwnghk/lobe-chat/issues/4049) ([8170889](8170889))

</details>

<div align="right">

[![](https://img.shields.io/badge/-BACK_TO_TOP-151515?style=flat-square)](#readme-top)

</div>
cy948 pushed a commit to cy948/lobe-chat that referenced this pull request Sep 21, 2024
@arvinxx @cy948
🐛 fix: pin [email protected] to fix code highlight (lobehub#4047)
582df0c
cy948 pushed a commit to cy948/lobe-chat that referenced this pull request Sep 21, 2024
@semantic-release-bot @cy948
🔖 chore(release): v1.19.14 [skip ci]
b1404f9 
### [Version&nbsp;1.19.14](lobehub/lobe-chat@v1.19.13...v1.19.14)
<sup>Released on **2024-09-20**</sup>

#### 🐛 Bug Fixes

- **misc**: Pin `[email protected]` to fix code highlight.

<br/>

<details>
<summary><kbd>Improvements and Fixes</kbd></summary>

#### What's fixed

* **misc**: Pin `[email protected]` to fix code highlight, closes [lobehub#4047](lobehub#4047) ([d12bf4c](lobehub@d12bf4c))

</details>

<div align="right">

[![](https://img.shields.io/badge/-BACK_TO_TOP-151515?style=flat-square)](#readme-top)

</div>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
🐛 Bug Something isn't working | 缺陷 released size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arvinxx @lobehubbot